Shane F. Carr

Results 2307 comments of Shane F. Carr

A more detailed review of #7219 suggests that the range is two-part: an extended year range of 1e6, coupled with an RD range of 3.66e8, where different constructors use different...

> There's also an assumption I haven't verified that the extended year range is narrower than the RD range in every calendar. For example, is the Ethiopic Amete Alem date...

> [@sffc](https://github.com/sffc) No, the RD range is just an early check: `from_rata_die` is the only constructor applying the RD range, and that calls down to calendar code, which _then_ will...

> I would prefer for there to be a single fundamental range being applied. Perhaps in that case it must be R.D, but that forces us to check R.D. on...

I think I value "round-trips through YMD" higher than "range boundary is at a year boundary" but I'm willing to be convinced otherwise if we can articulate the pros and...

I'm very confused then. I feel like we keep asking this question every month policy for which calendars go where. Is it written down anywhere?

A solution that is more consistent with how I see the role of Hijri Astronomical Simulation would be to take the AnyCalendar variant, mark it deprecated, make it use the...

It's regrettable that this landed with the title "Remove `Hijri` logic" which is not what this PR does, and is part of what negatively influenced my impression of this pull...

`-u-hc-` works. I don't think we have `hour12` except that you can mostly get that via `-u-hc-` but you need to choose between h11/h12 or h23/h24 instead of letting the...