Shane F. Carr
Shane F. Carr
> First off, I think this is too much work for the release driver, with our current process. We need better tooling/process before requiring this. As I've noted before, this...
> Are you saying that for the last few releases we have not been following the Unicode TC procedures? I doubt that. As Chair of the ICU4X Technical Committee, I...
TG2 discussion: https://github.com/tc39/ecma402/blob/master/meetings/notes-2023-12-14.md#add-option-to-use-variant-era-names-845 We will revisit when Temporal, Era Code, and Era Display are all landed.
In the other thread @robertbastian said > It's the same situation as the macro overload in the datetime crate. I've seen you tweak the datetime crate and what would be...
This particular macro is not nearly as complex as the datetime macro, and based on @Manishearth's consistent nudging to document internal APIs, I think it's not hard to learn to...
/gemini review, wdyt?
> The refactoring is a great improvement, making the code more concise and maintainable. > > Once these issues are addressed, this will be a solid improvement to the codebase....
> I've spent a good 10 minutes trying to understand how this works and have given up. This change is an immense readability hurdle; this code should be kept simple...
Also, we should normalize passing macros as arguments to other macros. It's a powerful technique that, while not the first thing you learn in Rust, greatly improves macro brevity and...