Shane F. Carr
Shane F. Carr
I find it a little hard to follow the categorization of traits. Here's my attempt: 1. Is the trait intended to be **implementable**? - If No: `Sealed` - If Yes,...
`feature = unstable` is not sufficient if the trait is used across crate boundaries, as you noted. The feature is only sufficient for me if the trait can be _fully_...
> This works for me, with the caveat that it should be "Not used cross-crate in any stable API". Not sure if I understand? If any stable API uses it...
@zbraniecki Here is the call site in Fuchsia: https://cs.opensource.google/fuchsia/fuchsia/+/main:src/lib/intl/lookup/rust/src/lib.rs;l=353 CC @filmil
Adding needs-approval so @filmil can weigh in
@zbraniecki points out that there is a Rust locale matcher crate that uses icu_locid, which may be an option for clients like Fuchsia.
My assertion is that if you're doing manual construction like that, you should be using the calendar-specific constructors like `Date::try_new_hebrew`. > because DateFields is #[non_exhaustive] this is even worse It's...
> > My assertion is that if you're doing manual construction like that, you should be using the calendar-specific constructors like `Date::try_new_hebrew`. > > Those constructors are not usable generically...
CC @makotokato @aethanyc
> I'm not a fan of the added phrasing. This checklist is an aid for the release driver to run the release, not a legal document restricting them. The Unicode...