Shane F. Carr

Results 636 comments of Shane F. Carr

Not currently, but this is a good idea. We obviously need to retain compatibility.

I wonder if Rust should define UB on each edition (2018, 2021, ...), and change the definition in tandem with the edition, in order to give maintainers an opportunity to...

FYI ICU ticket: https://unicode-org.atlassian.net/browse/ICU-12879 Most of the CLDR data for emoji are not exposed via ICU.

@NeilFraser Initial thoughts on this?

Probably what's happening is `diff_match_patch.utf32_string.from` is getting passed `text` that is already a utf32_string. Try adding a line to the top of that function that leaves if it is already...

Hi, thanks for finding these issues. I don't plan to spend any more time on my PR since it hasn't gotten any attention in 6 months. I encourage you to...

Looks like there are now at least 3 independent PRs with various approaches to fixing the issue: this one, #69, and #80. @NeilFraser Can you take a look at these...

I'm happy if #69 is enough to solve the issue; it's certainly a lot smaller of a patch than this one. There are a lot of code paths; I think...

I'm hacking in a copy of diff_match_patch locally. Haven't gotten something to completely work yet, but making some progress.