openems icon indicating copy to clipboard operation
openems copied to clipboard

WIP: Update Languages

Open Sn0w3y opened this issue 1 year ago • 10 comments

This PR consolidates all i18n.json files into a common format, enabling us to work on and improve them more efficiently in the future. The text in these files has been translated using translation services.

Also:

Processed all .html files in the app directory to replace occurrences of translation keys with their new uppercase equivalents. This includes both key and value replacements.

Updated all translation keys in the JSON language files to uppercase format.

The files use the de.json as a reference, as this was the most edited json :)

Sn0w3y avatar Jun 14 '24 20:06 Sn0w3y

Code Coverage

github-actions[bot] avatar Jun 14 '24 20:06 github-actions[bot]

Code Coverage

github-actions[bot] avatar Jun 14 '24 22:06 github-actions[bot]

@saeedniko: It seems @Sn0w3y has done the same work as you did :-( Can you please compare the PRs and review this one?

sfeilmeier avatar Jun 15 '24 17:06 sfeilmeier

@saeedniko I am sorry, i did not know about your PR :o

Sn0w3y avatar Jun 15 '24 20:06 Sn0w3y

@saeedniko: Thanks for checking it! How well did you review everything? Unfortunately @Sn0w3y has mixed structural changes (UPPER_CASE) with content (actual translations). This makes it very hard for me to review it.

@Sn0w3y: Did you use a script for all of this or did you do it manually? I would really prefer to do the changes in two separate PRs to be able to review everything in detail.

sfeilmeier avatar Jun 15 '24 20:06 sfeilmeier

Did you use a script for all of this or did you do it manually? I would really prefer to do the changes in two separate PRs to be able to review everything in detail.

Yes, i created a Python script for both - they still needed some manual Corrections but it worked pretty well.

Maybe i can split this PR up - I need to say i tested all locally and it worked flawlessly :)

My Goal was to provide a All-in-One Commit :)

Sn0w3y avatar Jun 15 '24 20:06 Sn0w3y

Code Coverage

github-actions[bot] avatar Jun 15 '24 20:06 github-actions[bot]

@Sn0w3y no problem, we did the same thing in the same way 😉

@sfeilmeier i looked for the "translate" directive in each file and checked how it had been changed. I just couldn't understand the changes in Japanese 😁

saeedniko avatar Jun 16 '24 07:06 saeedniko

I am putting this to WIP for now. We have an internal PR by @saeedniko with the same target that is currently under in-depth review by some colleages. I'll backport it afterwards.

We will update the translation keys only and not touch the translations for now. Especially the Japanese translations have been provided by native speakers, so we should not overwrite them with automated ones.

sfeilmeier avatar Jun 16 '24 10:06 sfeilmeier

We, Girasol Energy from Japan, will check UI carefully after you merged this.

JFYI, similar topic; In near future, maybe in next some months, we will make PR about formatting numbers for multi language support.

ikegam avatar Jun 20 '24 12:06 ikegam

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 19 '25 02:09 github-actions[bot]

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.

github-actions[bot] avatar Oct 11 '25 02:10 github-actions[bot]