Özkan Sezer

Results 570 comments of Özkan Sezer

You hit the delete or backspace key a little too much resulting in the following brokenness... ``` -# include +#endif# include ```

Simplified / cleaned up patch: ``` diff --git a/src/internal.h b/src/internal.h index 9ac17e0..62b235f 100644 --- a/src/internal.h +++ b/src/internal.h @@ -18,6 +18,8 @@ # if !defined(_GNU_SOURCE) # define _GNU_SOURCE # endif +/*...

> @sezero Hi, has your patch been merged into the repo? No. I just added my comments here to notify you of the issues in your patch, that's all.

Any comments please?

PING - anyone?

@madebr: cmake is your language, can you have a look? Reference issue: https://github.com/libsdl-org/SDL_mixer/pull/386#issuecomment-1133771043 Related commits: https://github.com/libsdl-org/opusfile/commit/264fc0df35a12569554d2a716d674d59ff3c86f1 https://github.com/libsdl-org/opusfile/commit/9ba5cc3dc920fb98f1b4068888d3c4e8617ef9b6