Özkan Sezer

Results 570 comments of Özkan Sezer

MSVC vendored libxmp build is failing because libxmp-vendored support isn't there: https://github.com/libsdl-org/SDL_mixer/blob/main/CMakeLists.txt#L585 Leaving things to @madebr

> Pushed initial work, hopefully correct and works. @slouken: your xcode project file needs updating after the 4.5.1 switch: - `../../external/libxmp/src/filetype.c` needs adding to sources. - `HAVE_ROUND` define no longer...

> @slouken: your xcode project file needs updating after the 4.5.1 switch: In addition, since you are building a dylib, do define `XMP_SYM_VISIBILITY` and build with `-fvisibility=hidden`

@slouken: Waiting your comments. See comments from `2021-02-05 12:16:44` - and later. (I miss Bugzilla...)

Adding Vitaly's mad duration patch here, so I don't lose it (and others may possibly review it, too.) [mad-tell-duration-patch.txt](https://github.com/libsdl-org/SDL_mixer/files/5998599/mad-tell-duration-patch.txt)

I guess we should detect `WAVE_FORMAT_MPEGLAYER3` (0x55) audio format tag in music_wav.c, seek to the `data` chunk and somehow 'forward' the SDLRW to a mp3 decoder built into SDL_mixer.

Possibly too late for 2.6.0. Mark for 2.8.0?

One way of doing it is that you use `Mix_LoadMUS_RW` and the RW is generated using `SDL_RWFromConstMem` where size is known. Other than that, what you request requires support from...

> My mp3 file package is in a large file, so I can only use SDL_RWFromFile What I meant is: If your mp3 files are not large, then you can...

> I just added support for MiniMP3, and switched to using that for MP3 support by default. [dr_mp3](https://github.com/mackron/dr_libs) would have been a better choice, maybe?