Özkan Sezer

Results 570 comments of Özkan Sezer

Same in SDL2 which SDL3 inherited the lack of return value checks from.

> is this fixed on head by #3135 ? In case the question is directed at me, I honestly don't know.

FWIW, the wasm32/simd256 test just failed in 0.9.x branch in our fork: https://github.com/libsdl-org/libjxl/actions/runs/7727268918/job/21065404323 ``` 99% tests passed, 1 tests failed out of 4414 Total Test time (real) = 1416.28 sec...

Like I said in original commit: The idea of FLAC files with ID3 tags?? I shall vomit... This may be one way of handling it. (Labeling a file starting with...

> Like I said in original commit: The idea of FLAC files with ID3 tags?? I shall vomit... And I wonder: how much should we care about flac files with...

Then I'd say that we don't apply this patch. @slouken, @icculus?

The previous version was https://github.com/libsdl-org/SDL_mixer/pull/521 / https://github.com/libsdl-org/SDL_mixer/issues/519

``` D:/a/SDL_mixer/SDL_mixer/src/codecs/music_fluidsynth.c:392:5: error: initialization of 'void (*)(void *)' from incompatible pointer type 'int (*)(void *)' [-Werror=incompatible-pointer-types] 392 | FLUIDSYNTH_Resume, | ^~~~~~~~~~~~~~~~~ D:/a/SDL_mixer/SDL_mixer/src/codecs/music_fluidsynth.c:392:5: note: (near initialization for 'Mix_MusicInterface_FLUIDSYNTH.Resume') ``` The problem...

> Let me know if you want that rolled up in one commit. Yes please. @slouken: Can you review? ( CC: @Wohlstand )