libmodplug avoid unaligned loads / stores

avoid unaligned loads / stores

Open sezero opened this issue 2 years ago • 8 comments

Closes https://github.com/Konstanty/libmodplug/pull/88

@ccawley2011, @AliceLR, @sagamusix: Please review.

Feb 24 '23 18:02 sezero

Will review soon when I get a chance.

Feb 24 '23 19:02 AliceLR

Re-opening after fixing accidental screw-up.

Feb 24 '23 22:02 sezero

@AliceLR: Pushed f93b2554 to load_med.c.

And yes: The other places are crawling with similar issues.

Feb 25 '23 12:02 sezero

Am I correct in thinking that this PR is meant to fix big endian compatibility as well?

Also, there's a Windows CE workaround in src/libmodplug/sndfile.h that can be removed now.

Feb 27 '23 09:02 ccawley2011

This seems about as fine as it can be without a much larger overhaul.

Other loaders will need similar changes, but yes it will be a much larger patch

Feb 27 '23 10:02 sezero

Am I correct in thinking that this PR is meant to fix big endian compatibility as well?

Yes (even though the comments in there say that it is big-endian-fixed)

Also, there's a Windows CE workaround in src/libmodplug/sndfile.h that can be removed now.

Looks like it

Feb 27 '23 10:02 sezero

Can we get this, #88, and #92 in please for portability? Does anyone other than @Konstanty have merge access?

Mar 20 '23 20:03 glebm

Can we get this, #88, and #92 in please for portability?

This patch fully replaces #88 I think, but otherwise yes, these ought to be merged ASAP.

Does anyone other than @Konstanty have merge access?

I think only @Konstanty can merge.

Mar 20 '23 20:03 AliceLR