Sebastian Mohr

Results 126 comments of Sebastian Mohr

Thanks! Let's merge this than :upside_down_face:

I just fixed the CI and merged it. Seemed like a nobrainer to me. Sorry for the long delay!

As far as I know it should be called `TPUB` not `LABEL` for mp3 files. See [here](https://id3.org/id3v2.3.0) for idv3 specs. This is also what mediafile [expects](https://github.com/beetbox/mediafile/blob/83157ca0f6643bab50e46f8d5378d062ae85fb39/mediafile.py#L1936-L1944). Are you using `TPUB`...

I think it should be no issue to add this to mediafile if it is a common problem. Can you find any documentation for this? I found https://docs.mp3tag.de/mapping/ which does...

I know how `TXXX` fields work. Im asking about docs or references because we can't just assume `TXXX:LABEL` is the same as `TPUB`. We need some precedence for it to...

For instance, a user might correctly employ these fields for entirely separate purposes: ``` TPUB = "Simon & Schuster" # The actual, factual publisher. TXXX:LABEL = "Gift from Sarah" #...

I understand the frustration. However, unlike some other, ID3v2 has a defined standard, and `TXXX:LABEL` falls under custom tags without a standardized meaning. That makes it harder to justify adding...

> I think the objective should be to refer to things the way they are actually called in the real world,  As I said from the beginning I'm on your...

Thanks for researching this a bit! This [comment](https://community.mp3tag.de/t/the-case-for-a-dedicated-label-tag/57647/17) was something I was looking for! Moved the issue to mediafile. I think we can act on that 👍 @JOJ0 you agree?

The actual changes to the plugin look good to me! Would you be open to rewriting the tests using pytest tho? It should be fairly straightforward and could significantly reduce...