Sebastian Mohr
Sebastian Mohr
I will have another look here and rebase it after we merge the #5814 PR.
Moved the docs changes into #5861. Feel free to have another look. Just rebased onto master and should good to go from my side.
While beatport has seen more significant updates, changes to the other plugins are minimal and primarily related to the MetadataSourcePlugin interface. For the spotify plugin, I introduced stricter types for...
> This may be my last comment 😅 Check the build for typing error, I think there's one popping up: > > ``` > Argument 1 to "append" of "list"...
I had a small look into the source and you could probably just quickly patch it by adding ```typescript parsableDate.toJsonSchema = () => ({ "anyOf": [ { "type": "string", "format":...
In theory format date or date-time means it complies with the [RFC 3339](https://datatracker.ietf.org/doc/html/rfc3339) specification. I'm not sure if the current `string.date.parse` functionalities fulfill the specification so using the regex might...
I think we can even add more indexes to optimize the join between `[item|album]_attributes` and `[album|item]` tables. We should be able to get even more improvements here. Keep in mind...
We would need some kind of migration system for the database schema change. In theory adding indexes is only a simple addition to the schema but a full fledged system...
> i*ve about 34 000 tracks and wihout the indexes i can see e.g. while using beets mv processed ~ 5min/file. With the index is ~300 times faster but still...
This looks like a more general issue affecting everything in [4.3.1 of the spec](https://id3.org/id3v2.3.0) The proposed fix will probably work, but it feels a bit hacky. What do you think...