Sebastian Mohr
Sebastian Mohr
Renaming does not really help me here :laughing: Where is the usecase for `list[tuple[Item, TrackInfo]]` over `Mapping[Item, TrackInfo]`? I feel like the later is cleaner if there is not a...
Btw I really appreciate that you started to properly type some parts in the commands submodule. I was hopeing someone would start with this after the bigger refactor :P
Since the PR was sitting for a bit I resolved the issues myself before we start to forget about this :upside_down_face:
> I didn't realise we've already been creating indices for attributes tables! I have seen that when creating the indices. For me the whole set of attribute tables seem a...
> See this blog post for more context regarding flexible attributes: https://beets.io/blog/flexattr.html. Certain implementation details can potentially be optimised, but the core concept is going to stay, I think. I...
@snejus @wisp3rwind I would like to revive this and merge it if we still think the changes are fine. I had another look here and still like the approach. I...
I was well aware of this and it was _intended_! It is a **migration** system by design, we need to get the existing indices to check if we need to...
> Could we start with the simpler approach and add migration infrastructure if/when we have concrete migration requirements? I'm genuinely trying to avoid premature complexity, not dismiss the value of...
I believe adopting the 1.2 specification is the right path forward. There was even some initial effort on this in #145.
No hurry! Take your time and enjoy the holidays.