Sebastian Mohr

Results 126 comments of Sebastian Mohr

Thank you for the bug report! I agree the error message is pretty confusing as the file does exist! I think the issue is not that the environment variables are...

To what values are your `VISUAL` and `EDITOR` variable set? For me setting both to none still opens my standard editor because of the open_aynthing fallback. https://github.com/beetbox/beets/blob/d446e10fb0a863ff5fad0d6106fd4acaad306fc2/beets/util/__init__.py#L948

Sure, please go ahead and give it a try! We’re always excited to welcome new contributors. You can find our getting-started guide [here](https://beets.readthedocs.io/en/stable/contributing.html#programming). If you run into any issues with...

As context: Maybe a macos user wants to enhance this a bit.

> > Seems like the issue was not catched earlier, since the typehints were > > not propagated correctly in the metadata_plugin.item_candidates function. > > I may be missing something,...

@snejus How do we want to continue here? The main concern was the duplication as far as I can remember. It might be possible to move the duplication check into...

I think the proposed change creates more problems than it solves. Maybe we are stuck here without a bigger refactor. Chroma does define `track_for_id` and `album_for_id` they just return empty...

@snejus How do we want to continue here? We could remove the `_parse_search_terms_with_fallbacks` function and revert to an inline approach, but I’m a bit concerned that an inline solution might...

I mean it kinda is, otherwise we would not have had this issue here (see [also](https://github.com/beetbox/beets/pull/6117/files#r2454351503)). It is not really about the complexity but ensuring the implementation is well defined...

The simple and stupid approach has introduced this issue and has allowed the desync to be introduced in the first place. I would like this a bit more controlled, either...