Sebastian Mohr

Results 126 comments of Sebastian Mohr

Thank you for the PR! I really appreciate it, this will make our lives much easier in the long run!

I'm not sure the gitblame is able to pickup the moved files but I can add it. > it doesn't require a major version bump Are we sure about that?...

> It seems like commits https://github.com/beetbox/mediafile/commit/cbc64e3e0903585e1865f7e80f92a2b066776ac7 and https://github.com/beetbox/mediafile/commit/0c6ccd4478e897e8ea908caafe76229ab5f01790 should be moved to https://github.com/beetbox/mediafile/pull/87, right? I could move them if you want. I would **not** put them into the uv PR...

> > Imports changed all over the place > > Internally, they have. However, from the perspective of an upstream consumer, they seem to still be available in `mediafile.py`. On...

> Those seem to have been private (prefixed by _), unless you made them private in the previous PR? It's indeed the only renaming I have done. We should be...

> Internally, they have. However, from the perspective of an upstream consumer, they seem to still be available in mediafile.py. On the other hand, I think we should add all...

> Also I think we should merge this one quickly and release it. if it's an alpha, it's ok if something is not ok 100% yet. Even though I think...

That's the reason why I want to do a proper 1.0.0 release to properly define the public api. See [here](https://github.com/beetbox/mediafile/pull/86#issuecomment-3446871917). I dont think we need to care about this too...

> > That's the reason why I want to do a proper 1.0.0 release to properly define the public api. See [here](https://github.com/beetbox/mediafile/pull/86#issuecomment-3446871917). I dont think we need to care about...

> Could you explain why do we have these imports in __all__ and nothing else? It was like this [before](https://github.com/beetbox/mediafile/blob/83157ca0f6643bab50e46f8d5378d062ae85fb39/mediafile.py#L60). Thought it might be useful to have the types exported...