Schuyler Eldridge

Results 234 comments of Schuyler Eldridge
trafficstars

Good catch, yes this should be updated. This probably needs two things: 1. An example using scala-cli. 2. An example with a main function. Anything related to `sbt` should be...

> I do have free time to help improve the docs. However, since I am a new Chisel user, if I am writing the docs, it might contain inaccurate information...

Good catch. I had thought those shared a common dependency, but they don't. Working on the update to _this_ image here: https://github.com/circt/images/pull/38

@teqdruid wrote: > I haven't looked over this PR, but this feels like it should be a dialect > attribute. Those have problems related to passes not retaining them though....

We discussed this internally and the rough consensus was that an attribute is definitely better. This is a relatively annoying lift, though. Alternatively, changing this to a single, variadic operation...

> What, AI isn't capable of making the change? It's more the implications of it. Currently unused inner symbols are being used for this and that is (assumedly) blocking optimizations...

Only if you can figure out how to enable AI code review on the project. 😉

@hovind: I merged that PR just now. Sorry about that. I didn't wind up actually needing that as I could point at the dated version of that. 🙃

Kicked off. (I'm not sure why that isn't setup on post-merge... 😓)

This was never implemented in CIRCT and, hence, this always incorrectly compiles to write first. There's an old tracking issue here: https://github.com/llvm/circt/issues/787 CIRCT passes should handle this if we are...