Konstantin Scheglov
Konstantin Scheglov
"A few seconds" seems too much. I wonder if it actually crashes and restarts. Do you have anything in `~/.dartServer/.analysis-driver/ex`? I have not tried myself yet. Yes, running macros is...
What specifically do you edit, so that you observe the slowness?
FWIW, I was not able to reproduce it so far, with the previous version of `JsonSerializable`, copied into my `test` package.
True, we do cache both compiled macro implementation in form of kernels, and resulting linked element models. And I *was* trying to with new code. I don't see how it...
No, there should be exactly one compilation, we have a lock on `KernelCompilationService`. And in general we have single execution flow in the analyzer. This is still surprisingly slow. Maybe...
> > No, there should be exactly one compilation, we have a lock on `KernelCompilationService`. > > Can we queue up a compilation for each edit possibly though? So it...
Might be confusing for users: I changed the macro, but nothing updated. If taken to extreme, we should not do analysis as you type too. Want to see errors and...
Yes, AFAIK it should by exported symbols, not only declared symbols. I know where the bug is in the analyzer :-)
https://dart-review.googlesource.com/c/sdk/+/370102
There are a few complications, at least in the analyzer. 1. When we ask ```dart var methods = await builder.methodsOf(superclassDeclaration); methods[0].returnType; ``` ...the method could have its `returnType` inferred from...