Konstantin Scheglov

> This is mostly about what we do while the macros code is _unlaunched_; to launch the analyzer package with the code we would indeed need to make it a...

These are special types, I would add `DynamicTypeDeclarationImpl` and `NeverTypeDeclarationImpl`.

OK, I understand that we provide "syntactic" APIs. Yeah, it is probably impractical to add `DeclarationsClassDeclaration`, so we will have to accept that it can be nullable. In the analyzer...

Oh, of course the same transformation should be done also when CFE, so that both analyzer and CFE produce identical code. I just was thinking how to implement it. While...

> > So, we need to build the whole code, then parse it, build scopes, and check every identifier reference. > > This sounds expensive to me? Wouldn't we also...

Alternatively, add `isAbstract` (not `hasAbstract`) for methods, but remove `hasBody`. The reason is that we consider `external` methods not abstract even though they don't have Dart bodies.

I agree that `hasBody` + `hasExternal` might work without `isAbstract`. Your comment about "isn't filled in yet" made me look at the documentation for `hasBody`, and it seems to state...

I don't know exactly how many, if any, internal generators we still have to migrate. @stereotype441 posted a few days ago that there was a small handful. And @srawlins actively...

https://dart-review.googlesource.com/c/sdk/+/446183

`FileState.referencingFiles` is currently used to say "these files semantically depend on this file", so if this file changes, we need to reanalyze these files (transitively). I think non-selected URIs probably...