Konstantin Scheglov

Results 222 comments of Konstantin Scheglov

@pq Not sure about the semantics here.

https://dart-review.googlesource.com/c/sdk/+/253705 will update the analyzer to evaluate default values, so unflake it.

Here is what I used locally. ```dart @reflectiveTest class ZZZTest extends PubPackageResolutionTest { solo_test_XXX() async { writeTestPackageAnalysisOptionsFile( AnalysisOptionsFileConfig( lints: ['avoid_redundant_argument_values'], ), ); final a = newFile('$testPackageLibPath/a.dart', r''' class Foo {...

FYI, https://dart-review.googlesource.com/c/sdk/+/253705 landed, and breaks Flutter at least once. Looks like exactly the issue with the lint that this issue is about. ``` Analyzing 3 items... info • Avoid redundant...

True, as I described above, my change it to make it not flake. Which means that the lint rule now always reports the lint. We still need a fix (again,...

This feature actually touches quite a few places in the analyzer, and how we resolve generic invocations, with quite large historical baggage, so cannot be done quickly. I don't have...

First of all, switch to using `analyzer_plugin 0.11.1`, so that it uses `AnalysisContextCollection`, just like the main analysis server does. Don't use `AnalysisDriverGeneric` and `createAnalysisDriver()`. And the new `ServerPlugin` class...

From the analyzer POV I don't see any difference between implementing invocation `super augment foo()` and tear-off `super augment foo`.

We have in `DartType`: ```dart /// If this type is an instantiation of a type alias, information about /// the alias element, and the type arguments. /// Otherwise return `null`....