Konstantin Scheglov

icon company Google icon location Portland, OR, USA

Results 222 comments of Konstantin Scheglov

[analyzer] Report a compile-time error when an expression of type `void` is used

![image](https://github.com/dart-lang/sdk/assets/384794/3103e3b7-fe30-4b9e-a112-92bb4245ef1a)

Some analysis_server tests produce invalid analysis_options.yaml files due to passing an empty list for experiments instead of null.

It seems to me that it would be cleaner to give default `const []`, and check for `.isNotEmpty` instead of `!= null`.

Some analysis_server tests produce invalid analysis_options.yaml files due to passing an empty list for experiments instead of null.

These are `@SkippedTest` that we were not able to make reliable.

Analyzer crashes when a file contains both a `part` and `part of` in the same file.

I cannot reproduce it. The test below reports some errors, but no crash. ```dart solo_test_X() async { newFile('$testPackageLibPath/a.dart', r''' part 'test.dart'; '''); await assertErrorsInCode(r''' part 'a.dart'; part of 'a.dart'; ''',...

Analyzer crashes when a file contains both a `part` and `part of` in the same file.

Sorry, yes, you are right, there is a syntactic error. I was mostly saying that there is no crash, and kind of the diagnostic did not seem important then :-)...

Analyzer should report an error for macro applications too close to the macro impl

https://dart-review.googlesource.com/c/sdk/+/354382

[analyzer]: null issues when running Zapp (which embeds the analysis server on a web client)

It seems that there is too much context. What code do you try to analyze, on which the analyzer crashes?

[analyzer]: null issues when running Zapp (which embeds the analysis server on a web client)

Well, given that the analyzer when running in Dart VM can analyze "hello world", it might be: 1. Something that we wrote in the analyzer that does not follow the...

[analyzer]: null issues when running Zapp (which embeds the analysis server on a web client)

I'm not 100% sure, but the extra empty component in `ElementLocation` might be the name of the unnamed constructor. Given the warning with `main`, with the knowledge that we use...

[analyzer]: null issues when running Zapp (which embeds the analysis server on a web client)

Interesting, why is it for `30` bits, not `52` or `53`, whatever weird number of bits JavaScript uses for `int`?