Konstantin Scheglov

https://github.com/dart-lang/sdk/issues/51985 is open because we need support from `_fe_analyzer_shared` to get more than one witness for a failed exhaustiveness validation. But I don't think this is high priority. I'm against...

One complication with looking into function bodies is that this affects how the analyzer decides which changes affect a library API. Normally bodies of top-level functions never affect the API,...

As it is implemented in the analyzer right now, we compute "API signature" of a file based on its parsed AST, without any resolution. So, we don't know whether there...

Note, that until the declaration phase ends we cannot resolve metadata, because at any point a new declaration could be added, and so change the resolution. ```dart import 'package:my/macro.dart' show...

We probably cannot disallow using local declaration for all metadata. But it would be reasonable for annotations that are macro references. Probably mostly such configuration will be primitives - `String`...

I could add missing APIs and publish the analyzer. However some of these are missing because corresponding token sequence is not parsed. I vaguely remember this being the case for...

I think it is ideologically wrong to write copies of the parser, even simplified ones.

I was not able to reproduce this. Does it generate the same error using pure Dart code?

@jmesserly @leafpetersen Who might know better about types in analyzer.

tl;dr we do support macros People using `package:analyzer/dart/analysis/context_builder.dart` should migrate to `AnalysisContextCollection`, which provides default way to run macros. https://github.com/dart-lang/sdk/blob/5e68eee8c33c55efc687cab3516fa7fef4b2ecd9/pkg/analyzer/lib/src/dart/analysis/analysis_context_collection.dart#L89 In general, `ContextBuilder` is an older attempt to API, and...