Konstantin Scheglov

Results 222 comments of Konstantin Scheglov

@eernstg Yes, the example in https://github.com/dart-lang/linter/issues/2084#issuecomment-624491318 has no errors when `non-nullable` experiment is enabled. My example in https://github.com/dart-lang/linter/issues/2084#issuecomment-624330259 was specifically for legacy code. In analyzer we have separate logic for...

A couple of ideas. 1. In `_addSuperTypesAsSuggestions` use `InterfaceElement.allSupertypes` instead of diving into `get interfaces` and using `alreadyAdded`. 2. The name `_addSuperTypesAsSuggestions` is not quite correct - it adds the...

I actually find this terminology somewhat confusing, maybe because different people mean different things. For me, when I see "class", it means actual "class X {}" or `mixin X {}`....

I have not seen it for a while.

1. How big is the file in which you type and get slow completions? 2. How many other libraries import this file, directly or indirectly? 3. How many libraries the...

1. 300 lines is not much, OK. 2. This does not answer my question. You listed flutter libraries, I doubt they import the file where you have performance problem with...

2. This is weird. Then analysis and completions should be very fast. 3. Ah, OK. Yes, this is what I asked. Again, not too many libraries, should be fast. We...

I think this feature (or similar) exists now in Flutter plugin - format and organize imports on save. ![image](https://user-images.githubusercontent.com/384794/39649241-02714866-4f9a-11e8-8a9f-d0dfede333b1.png)

@jwren worked on move / rename refactoring support in DAS.

* Yes, we are moving in the direction of not including suggestions from other libraries, if there is already a suggestion for the same element from an already imported library....