Spencer Bryngelson
Spencer Bryngelson
> > > > Can you add goldenfiles/tests since we now have examples? Even if they are only for 0D or 1D. this would also help ensure the user has...
Why did they fail? If you didn't change how those tests were being run, the tests should pass as they do on the normal master branch, right? Or did you...
Benchmarking is failing with ```console .=++*: -+*+=. | [email protected] [Linux] :+ -*- == =* . | ------------------------------------------------------- :*+ == ++ .+- | :*##-.....:*+ .#%+++=--+=:::. | --jobs 24 -=-++-======#=--**+++==+*++=::-:. | --mpi...
@henryleberre mind pulling from upstream for 'cleanliness'? I made an update there yesterday and want to see how it worked out.
Can be merged once CI passes + merge conflicts resolved.
I opened a companion issue to fix the broken CI cases: https://github.com/MFlowCode/MFC/issues/751 @okBrian
@henryleberre pull my 'fix cleanliness' PR so it's up to date with master if possible (that's the thing I would like to test).
> Testing this is a bit harder because it only appears meaningfully in multi-rank cases. Once you're done, can you test for correctness on a longer 4-rank case, for example,...
> > Testing this is a bit harder because it only appears meaningfully in multi-rank cases. Once you're done, can you test for correctness on a longer 4-rank case, for...
> > > Testing this is a bit harder because it only appears meaningfully in multi-rank cases. Once you're done, can you test for correctness on a longer 4-rank case,...