MFC icon indicating copy to clipboard operation
MFC copied to clipboard

Fixed Examples, Added Examples CI.

Open okBrian opened this issue 1 year ago • 3 comments

Description

Reduced Example Test cases and added to CI Fixed examples Fixed bugs breaking some of the examples

Currently skips these examples: ["2D_ibm_cfl_dt", "1D_sodHypo", "2D_viscous", "2D_laplace_pressure_jump", "2D_bubbly_steady_shock", "2D_advection", "2D_hardcodied_ic", "2D_ibm_multiphase"] Fixes #474

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Something else

Scope

  • [x] This PR comprises a set of related changes with a common goal

How Has This Been Tested?

  • [x] Github CI
  • [x] Locally on a Ubuntu VM with intel compilers, and my compiler with GCC 14.2

Test Configuration:

  • What computers and compilers did you use to test this:

Checklist

  • [x] I have added comments for the new code
  • [x] I ran ./mfc.sh format before committing my code
  • [x] This PR does not introduce any repeated code (it follows the DRY principle)
  • [x] I cannot think of a way to condense this code and reduce any introduced additional line count

okBrian avatar Oct 28 '24 17:10 okBrian

This seems good to me. What options did you use to generate the goldenfiles? If debug, can you open a GitHub issue on MFC to force debug mode when generating new goldenfiles?

Also requesting review from @henryleberre particularly on the toolchain/ in case there's something that should be adjusted there.

sbryngelson avatar Oct 28 '24 21:10 sbryngelson

This seems good to me. What options did you use to generate the goldenfiles? If debug, can you open a GitHub issue on MFC to force debug mode when generating new goldenfiles?

They are generated with default settings ie (MPI, no-debug, intel: false), so no need for anything special.

okBrian avatar Oct 29 '24 18:10 okBrian

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.87%. Comparing base (d1b8028) to head (f7294c3). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/post_process/m_data_input.f90 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
+ Coverage   43.63%   45.87%   +2.23%     
==========================================
  Files          61       61              
  Lines       16893    16915      +22     
  Branches     1948     1962      +14     
==========================================
+ Hits         7372     7759     +387     
+ Misses       8404     7942     -462     
- Partials     1117     1214      +97     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 31 '24 00:10 codecov[bot]

Considering 175 Base Test cases are breaking on Phoenix CPU after I ran it, I am going to regenerate the base test suite.

okBrian avatar Oct 31 '24 17:10 okBrian

Why did they fail? If you didn't change how those tests were being run, the tests should pass as they do on the normal master branch, right? Or did you change the tolerances of the tests or something else?

sbryngelson avatar Oct 31 '24 17:10 sbryngelson

Oh yeaaa, why am I regenerating them. it seems to be a different issue , so I will look into it.

okBrian avatar Oct 31 '24 18:10 okBrian

Can be merged once CI passes + merge conflicts resolved.

sbryngelson avatar Nov 08 '24 21:11 sbryngelson

I opened a companion issue to fix the broken CI cases: https://github.com/MFlowCode/MFC/issues/751 @okBrian

sbryngelson avatar Dec 03 '24 19:12 sbryngelson