Spencer Bryngelson

Results 234 comments of Spencer Bryngelson

closed by @Malmahrouqi3 by [Updated Bridges2 Modules (CPU/GPU) #905](https://github.com/MFlowCode/MFC/pull/905)

> @okBrian after talking with @sbryngelson about this, I made a branch with a commit to help kickstart this: [henryleberre/ChemMFC@`henry`/474](https://github.com/henryleberre/ChemMFC/tree/henry/474?rgh-link-date=2024-07-04T10%3A40%3A45Z). The code adds a new test case for each example....

I see that I get `NaN` on my local machine in the timestep performance output for `1d_impact` (haven't checked other cases). ```console [ 99%] Time step 198 of 201 @...

> > > @okBrian after talking with @sbryngelson about this, I made a branch with a commit to help kickstart this: [henryleberre/ChemMFC@`henry`/474](https://github.com/henryleberre/ChemMFC/tree/henry/474?rgh-link-date=2024-07-04T12%3A51%3A52Z). The code adds a new test case for...

Not needed. Just need to add a debug runner now.

This can presumably also be used anywhere `H` is computed, which is in several other places (@okBrian this is useful for you as well) * https://github.com/MFlowCode/MFC/blob/2651071efb76d157aa552da1e7fafdc9b4d19fee/src/simulation/m_cbc.fpp#L769-L808 * https://github.com/MFlowCode/MFC/blob/2651071efb76d157aa552da1e7fafdc9b4d19fee/src/simulation/m_data_output.fpp#L252-L276 * https://github.com/MFlowCode/MFC/blob/2651071efb76d157aa552da1e7fafdc9b4d19fee/src/simulation/m_riemann_solvers.fpp#L1270-L1328...

Excellent! Glad to have new features. I still need to do code review...

Having a look... in the meantime I found this ``` Failed test tests/16A922E4: 1D -> weno_order=3 -> mapped_weno=T after 3 attempt(s). ``` which follows from your ``` mapped_weno is not...

> It's probably a dependency issue: On the newest commit, a fresh build works, but afterwards, if I modify anything in m_weno.fpp, even if it's just a comment, the compilation...

It's unclear why WENO7 is incompatible with grid stretching? We use the stretching feature often.