Spencer Bryngelson

I propose moving all monopole source terms in `m_rhs.f90` into a new module (`m_monopole.f90`) and viscous terms (which right now are in a separate subroutine in `m_rhs.f90` to yet another...

Bubble code is not in `m_rhs`?

1

This code used to be in the `m_bubbles` modules, but now it's also in `s_compute_rhs`? Also, `s_compute_rhs` is 1863 lines long. https://github.com/MFlowCode/MFC/blob/ecbcb72cc93563bb071118c447e84c3dabdf6341/src/simulation/m_rhs.f90#L1113-L1321

Dead code

1

Dead code needs to me removed. We seem to have thousands of lines of it. Here is one example: https://github.com/MFlowCode/MFC/blob/fc40ccea496abd8e3b81a543c6b5ba80af589dfb/src/simulation_code/m_rhs.f90#L358-L544 We also have two entire RHS functions: https://github.com/MFlowCode/MFC/blob/fc40ccea496abd8e3b81a543c6b5ba80af589dfb/src/simulation_code/m_rhs.f90#L2928 https://github.com/MFlowCode/MFC/blob/fc40ccea496abd8e3b81a543c6b5ba80af589dfb/src/simulation_code/m_rhs.f90#L1010 The...

Module files are simply too long

1

Our module files are simply too long, no matter how you think about the code abstractions. I suggest that modules should not be longer than 1000 lines, though much shorter...

Equation of state is not DRY

3

The equation of state is used to compute the pressure from the variables. This EOS changes slightly for different models. The EOS implementation is repeated several places in the code,...

contributors guide

2

Need a file on how to contribute to MFC.

This adds the extension `.fpp` to the Modern Fortran language, which is associated with [Fypp](https://fypp.readthedocs.io/en/stable/fypp.html) metaprogramming files for Fortran. These files have the same syntax as usual free-form Fortran except...

Fix benchmark divide by zero with proper error message

3

I'm not sure why it happens but we have an issue where we sometimes get a divide by zero in benchmark diff (e.g., https://github.com/MFlowCode/MFC/actions/runs/8610942830/job/23597260867?pr=285): ``` .=++*: -+*+=. | [email protected] [Linux]...

CI Benchmarking reports opposite results

5

The CI Benchmarker reports `master is X times faster than PR` (or something like this) but in reality it is actually reporting `master is X times slower than PR`. This...

Use floating point division for benchmarking

1

Right now benchmarking recording input and outupt time in full seconds, resulting in weird numbers when the numbers are close or the same. We can fix this by modifying the...