Spencer Bryngelson
Spencer Bryngelson
Nice. I think a 'TSTEP-SUBSTEP' range makes sense (for RK3 you have 3 such substeps). This helps consolidate things. Related to #631
@max-Hawkins would you mind updating/finish this for merge?
needs `./mfc.sh format -j 4` edit: nvm
Thanks! A beauty. Merging.
This seems obviously useful and helpful, the concern is with costs. What does the change in cost look like for a typical 3D problem on (a) 1 CPU and (b)...
Useful feature but needs more attention when time is available.
This works with NVHPC, but not CCE compilers, in the GPU case (error is something like "collapse requires perfectly nested do loops") [FYI @abbotts ]. I reproduced it on a...
@henryleberre created this that does the trick: ```fortran #:def forall(*args) #:for loop in args[:-1] do ${loop}$ #:endfor $:args[-1] #:for _ in range(len(args)-1) end do #:endfor #:enddef program forall_example implicit none...
This seems good to me. What options did you use to generate the goldenfiles? If `debug`, can you open a GitHub issue on MFC to force `debug` mode when generating...
> > Can you add goldenfiles/tests since we now have examples? Even if they are only for 0D or 1D. this would also help ensure the user has installed boost/pyro...