Samuel Karp

Results 341 comments of Samuel Karp

@dmcgowan I did notice issues with `"."` in the Protobuild file too. Closing; this is mostly addressed by https://github.com/containerd/protobuild/pull/54 and the gap can be followed up separately.

In the two years since I opened this (and that I apparently forgot it was open), the results I'm getting (now on FreeBSD 13.1-RELEASE) are slightly different: ``` --- FAIL:...

@tianon did a good job of channeling what I was going to say, but I'll use my own words too :smile: > Finally, I understand if you consider this enhancement...

> #freebsd channel on the CNCF Slack Oh, one more thing: I think @tianon meant to refer to the OCI Slack: https://chat.opencontainers.org/

Thanks again for opening this and showing me how to properly invoke the jail syscalls. I've adapted some of the work you did here into https://github.com/samuelkarp/runj/commit/398df9a0deea637af3062df1cf846a8d5d11bd49 and pushed that; as...

My initial plan was to open issues for the things that needed work done and mark whether I had planned to do them myself or wanted help, but I seem...

I've opened https://github.com/samuelkarp/runj/issues/20 to specifically cover networking and leave this issue open for its original purpose.

> I'm a little bit nervous that this seems to directly leak the RACCT resource names directly into the config file format. It doesn't look like that to me; @cyrilzhangfreebsd...

I spent some time reading [`rctl(8)`](https://www.freebsd.org/cgi/man.cgi?query=rctl&sektion=8), [`rctl(4)`](https://www.freebsd.org/cgi/man.cgi?query=rctl&sektion=4&apropos=0&manpath=FreeBSD+13.0-RELEASE+and+Ports), and [`rctl.conf(5)`](https://www.freebsd.org/cgi/man.cgi?query=rctl.conf&sektion=5&apropos=0&manpath=FreeBSD+13.0-RELEASE+and+Ports) as well as the Linux portions of the runtime spec. > I think it would make sense to start by defining...

Here's a potential alternative sketch: ```go type FreeBSD struct { Resources *FreeBSDResources `json:"resources,omitempty"` } type FreeBSDResources struct { // Memory is the memory restriction configuration Memory *FreeBSDMemory `json:"memory,omitempty"` // FSIO...