protobuild icon indicating copy to clipboard operation
protobuild copied to clipboard

support paths=source_relative

Open samuelkarp opened this issue 2 years ago • 2 comments

paths=source_relative enables protobuild to work when a project is checked out to a directory not located in the GOPATH.

samuelkarp avatar Jun 21 '22 06:06 samuelkarp

This was able to work for you in the containerd main project as well? I'll have to test this one out since it is a common issue I have.

dmcgowan avatar Jun 21 '22 17:06 dmcgowan

Does this still work having before = ["."] in the Protobuild file? I noticed with this change it wasn't able to resolve a local file unless I converted "." to the real path, which shouldn't be in the Protobuild file obviously.

dmcgowan avatar Jun 25 '22 00:06 dmcgowan

@dmcgowan I did notice issues with "." in the Protobuild file too.

Closing; this is mostly addressed by https://github.com/containerd/protobuild/pull/54 and the gap can be followed up separately.

samuelkarp avatar Sep 06 '22 04:09 samuelkarp