Samuel Karp

> So we can certainly include those in the snap but they'll just live in /var/lib/snapd/snap/whatever so I'm not certain how useful it would be. That's fine, I'd rather have...

Looks like https://github.com/docker-snap/docker-snap/issues/10 covers some complications that would make it hard to use both the Docker snap and a snap of this credential helper together.

> I think I'm running into this issue. Is this considered a bug that will be fixed? Is there a workaround? Hey @cwiggs! As of now, I don't have a...

I'd be happy to take PR adding documentation about this! This issue is here to remind me to do it, but it's always nice when folks volunteer to help.

Hi @cjhubert and @jeremygaither! I haven't tried using the credential helper with `mfa_serial` and I'm not sure whether it will work today. The credential helper should write logs to `~/.ecr/log/ecr-login.log`;...

Thanks for the logs! > ``` > Error retrieving credentials" error="ecr: Failed to get authorization token: AssumeRoleTokenProviderNotSetError: assume role with MFA enabled, but AssumeRoleTokenProvider session option not set. > ```...

https://github.com/golang/go/issues/33772 appears to still be an issue for Go 1.13 (see https://github.com/golang/go/issues/34326 for when the fix is backported).

@Tomdarkness Apologies for the delayed response here. As @gengmao explained, the credential helper needs to know what region it should use in order to get credentials for the default registry...

> can i suggest that the plugin should also honor if AWS_DEFAULT_REGION variable is present rather than only searching for AWS_REGION. @man-jiteshm-sportsbet I'd be happy to take a pull request...

I've opened https://github.com/awslabs/amazon-ecr-credential-helper/issues/251 to track the need for better documentation of limitations related to `docker build`.