Samuel Karp comments

Results 341 comments of


                                            Samuel Karp

Upgrade to aws go sdk v2 for cloudwatch logging driver

@kzys might be able to help here?

add metrics for image pulling: error; in progress count; thoughput

``` * b8de211b "renames; image pull count all and add registry/status as label" ... FAIL - PASS - commit does not have any whitespace errors - FAIL - does not...

add metrics for image pulling: error; in progress count; thoughput

Can you rebase on `main`? There's a fix for `TestSandboxRemoveWithoutIPLeakage` which is currently flaking CI on this PR.

containerd: promethus metrics could be partially supported

Can you describe more of your motivation for making this change?

Fix "getCPUInfo for OS freebsd: not implemented" on FreeBSD/arm64

> How about using sysctl? golang/go#47006 (comment) > What is the negative side-effects of detecting ARMv7 as unknown? If it doesn't have any, I'm fine having a stopgap solution for...

WIP: CRI: Sandbox support user namespace. part I

@wllenyj You may also want to wait for https://github.com/containerd/containerd/pull/7426 to be merged to start work on the sbserver implementation too.

Fix the env cannot be overridden in `config.json`

Please sign your commit with your [real name](https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work).

Fix the env cannot be overridden in `config.json`

/ok-to-test

CRI: fix CDI device injection in k8s case

Please sign your commit using your [real name](https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work).

CRI: fix CDI device injection in k8s case

/ok-to-test