Samuel Ainsworth

Results 211 comments of Samuel Ainsworth

Hey @playerdefault ! A lot of the internals of busybox, and by extension rustybox, are designed specifically around linux, but I would definitely be open to PRs that move us...

It's worth mentioning that there are also a bunch of constants that are "declared" but that are copied across many different files and modules. Ultimately these should be de-duped.

In order to get a completely static binary, you'll need to use the `x86_64-unknown-linux-musl` target instead of `x86_64-unknown-linux-gnu`: https://doc.rust-lang.org/edition-guide/rust-2018/platform-and-target-support/musl-support-for-fully-static-binaries.html. I'm not sure that rustybox will immediately compile this way, but...

Yeah, there will definitely be errors since this was c2rust'ed with glibc. But they should all be pretty similar and rustybox will be better for having them fixed!

Thanks for the pointers @kellda ! I wasn't aware that busybox had issues building with musl. Getting a static build working would be great. I think the main blocker is...

> Hi, is there progress with rustybox / static musl build? No, still in the same situation. OOC what do you need a static build for?

That would be cool! Based on my experience with c2rust so far, I think the easiest way forward is to do by-hand rewrites in rust for most new applets, but...

It's kind of weird right now... Busybox is GPL and rustybox is obviously transpiled from that. I'm not a lawyer, so I guess I'm just letting users figure out however...

> I don't know why they made wget and nc but no curl command. No idea! Happy to have them in rustybox though! I think the ideal situation will be...

Thanks for clarifying @vfdev-5 and @zou3519! I'll just disable the failing tests for now. > @samuela Do you have latest nightly pytorch version ? I'd say you can skip coverage...