Abdul Malik Ikhsan
Abdul Malik Ikhsan
Looking at the rule, it seems we can do: "inline_public" config instead, that's will make less destructive when choose which rule that needs to allow add type on "public/protected" proprerty/const....
I created 2 alternative PRs: - https://github.com/rectorphp/rector-src/pull/6974 - https://github.com/rectorphp/rector-src/pull/6975 I prefer "**alternative 2**" option, as this feel less destructive, and more "inline_public" with other typed rules: - https://getrector.com/rule-detail/class-property-assign-to-constructor-promotion-rector - https://getrector.com/rule-detail/typed-property-from-assigns-rector
Let's close this as implemented 👍
@peterfox rebase is needed, ensure it works with the way phpstan 2 and phpdoc-parser 2 detect it on latest main.
what the different between pass `-1` and `0`? using cast `(int) NULL` result `0` if we are going to using cast for similar transform
Reading documentation, it seems pass `0` or `-1` is equal: ``` limit ---- If specified, then only substrings up to limit are returned with the rest of the string being...
I created PR: - https://github.com/rectorphp/rector-src/pull/7240 for it.
The branch seems conflict, could you rebase? Thank you.
is the diff default selected after submit or uri has hash target demo? If yes, then i'm ok with this.