Abdul Malik Ikhsan

icon indicating a website link http://samsonasik.wordpress.com icon indicating an email [email protected]

icon company Sitrun Technologies icon location Bandung, Indonesia icon location A father

Results 372 comments of Abdul Malik Ikhsan

[Experiment] Use composer.json as priority, fallback to php version features on when parameter exists on ComposerJsonPhpVersionResolver

I created separate PR to remove duplicated register ContinueToBreakInSwitchRector that exists in both `php52` and `php73` config - https://github.com/rectorphp/rector-src/pull/6385

[Experiment] Use composer.json as priority, fallback to php version features on when parameter exists on ComposerJsonPhpVersionResolver

All checks have passed 🎉 @TomasVotruba it is ready for review. I don't rebase cherry-pick patch https://github.com/rectorphp/rector-src/pull/6385 so you can see the process and how it found a bug with...

[Experiment] Use composer.json as priority, fallback to php version features on when parameter exists on ComposerJsonPhpVersionResolver

Closing for now

/ast page should not use FullyQualified on return true

It seems only happen on non-namespaced file https://getrector.com/ast/d50f4d493f7061f3c419397a744a49e92409c3ce?nodeId=7 when has namespace, it not fully qualified https://getrector.com/ast/fbf1401fbd04dfd5e9a0858f4936a39ed66cc4dd?nodeId=9

/ast page should not use FullyQualified on return true

It seems bug on nikic/php-parser on NameContext https://github.com/nikic/PHP-Parser/blob/fa02db3f30ecdee4142bed51b860e1e3ca20bb5a/lib/PhpParser/NameContext.php#L124-L127 The `getNamespaceRelativeName()` should be called first.

/ast page should not use FullyQualified on return true

I created PR on php-parser side: - https://github.com/nikic/PHP-Parser/pull/1067

[e2e][Printer] Handle crash indentation on AddParamBasedOnParentClassMethodRector

Fixed 🎉 /cc @RuesimOfCode

[e2e][Printer] Handle crash indentation on AddParamBasedOnParentClassMethodRector

All checks have passed 🎉 @TomasVotruba I think it is ready.

[e2e][Printer] Handle crash indentation on AddParamBasedOnParentClassMethodRector

I can't approve my own PR, i think this is ready, just probably concern about renaming method bc break :)

[TypeDeclaration] Skip mixed as on right of and on ParamTypeByMethodCallTypeRector

Fixed 🎉 /cc @staabm