Abdul Malik Ikhsan
Abdul Malik Ikhsan
@TomasVotruba sure, phpstan 2 require php-parser 5 so it will need revisit my old PR: - https://github.com/rectorphp/rector-src/pull/2916 to be reincorporated ;)
sure, see https://github.com/rectorphp/rector-src/pull/6415
I am trying to install phpstan 2 and php-parser 5 - https://github.com/rectorphp/rector-src/pull/6431 the php-parser is patched, and currently got error on phpstan service: ``` 44) Rector\Tests\Issues\AutoImport\AutoImportTest::test with data set #43...
The parameter list seems different: v1: https://github.com/phpstan/phpstan-src/blob/fd6a0f275f2a4d6dd21c450bb4d0a55d0ee1e43c/src/Parser/RichParser.php#L43-L45 v2: https://github.com/phpstan/phpstan-src/blob/2a200beec3f2edd913b2af3bf69fbb428018dd74/src/Parser/RichParser.php#L42-L44
Remove lexer params seems handle it https://github.com/rectorphp/rector-src/pull/6431/commits/f7e9549cc33ae47fa6b6de665e7384c6f0eb118b will continue updating there at: - https://github.com/rectorphp/rector-src/pull/6431
The upgrade process has been completed 🎉 🎉 🎉 - https://github.com/rectorphp/rector-src/pull/6431#issuecomment-2486747057
https://github.com/rectorphp/rector-src/pull/6475
@simonschaufi I created PR on typo-3 rector for that :) - https://github.com/sabbelasichon/typo3-rector/pull/4450
@ruudk It because of this PR: - https://github.com/rectorphp/rector-src/pull/6438 `getRuleDefinition()` no longer exists in shipped rector/rector, to ease for write custom rule without define `getRuleDefinition()` method. You can remove `#[Override]` on...
@ruudk I created PR for that for win win solution: - https://github.com/rectorphp/rector-src/pull/6476