Abdul Malik Ikhsan

Results 372 comments of Abdul Malik Ikhsan

Re-open, assign inside condition seems needs special check, also the `ExplicitBoolCompareRector` seems not using `ExactCompareFactory`

Could you reproduce at https://getrector.com/demo ? Thank you

I am closing it as no code and config provided. If I check your example, it seems you're changing smarty, that third party vendor, my suggestion is to not change...

The error seems from phpstan: ``` ➜ test-php84 vendor/bin/rector process src -vvv [ERROR] Could not process "/Users/samsonasik/test-php84/src/test.php" file, due to: "System error: "Call to undefined method Symfony\Polyfill\Mbstring\Mbstring::mb_ucfirst()" Stack trace: #0...

The error seems still happen even `mb_ucfirst` is not called: ![Screenshot 2024-06-28 at 10 39 18](https://github.com/rectorphp/rector/assets/459648/fc1162de-fe82-4185-8206-f30eef3625ce)

Oh, I edit the wrong file, when `mb_ucfirst` not called, it working ok ``` ➜ test-php84 vendor/bin/rector process src/test.php --dry-run 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% [OK] Rector is done! ```

I guess the patch needs to be in phpstan-src itself, as it got error on phpstan.org https://phpstan.org/r/4aa0a8d2-809b-472b-a406-6d085b4781aa and stack trace shown on phpstan: ``` [ERROR] Could not process "src/test.php" file,...

Let's remove this from 3.16.0 so we can move forward to support php 8.4

implemented :tada:, here the summary: This PR provide a way to set `withPhpVersion()` even `composer.json` not exists or doesn't define `"php"` config, so it fallback php version feature defined, with...