Abdul Malik Ikhsan
Abdul Malik Ikhsan
Just a quick read, if I understand correctly, the constant is not deprecated (yet) in php 8.4, it just replaced in core code, so I think it is not really...
I prefer to have downgrade rule instead first then, as replace constant is not required, but once it upgraded to enum, it needs to have downgrade rule to back to...
Thank you @jorgsowa
That seems possible with: 1. verify parentheses exists first 2. re-print the node: ```php $node->setAttribute(AttributeKey::ORIGINAL_NODE, null); ``` _The caveat_, this should only apply on dedicated as `Expression` Stmt or direct...
@palaueb after some thinking, I think it is better to use coding standard tool for it, for example, if you use ecs enable `PhpCsFixer\Fixer\ControlStructure\NoUnneededControlParenthesesFixer` and `PhpCsFixer\Fixer\LanguageConstruct\SingleSpaceAroundConstructFixer`, you will get output:...
@shakaran could you create fixture PR for it for input and expected output at https://github.com/rectorphp/rector-symfony/tree/1a199fc1af9885bb647b160a5be218f69f4e6338/rules-tests/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture ? Thank you.
@gharlan feel free to provide fixture PR, thank you.
Please create failing fixture PR guys, otherwise, it won't fix by itself :)
I am going to close it then, if you have a chance to create expected failing fixture, feel free to create PR :)
I am closing it as lack of feedback and don't have simple repository to reproduce, feel free to re-open the issue with provide simple reproducible repo so we can check...