Abdul Malik Ikhsan
Abdul Malik Ikhsan
Downgrade first rule ready at: - https://github.com/rectorphp/rector-downgrade-php/pull/313
implemented at PR - https://github.com/rectorphp/rector-src/pull/7213
The result seems valid, see https://3v4l.org/D3TDJ , the rule is on php 7.0 migration, not php 5.x and it show valid and equal result, could you show me which one...
The rule is for php7.0 upgrade, not php 5.6, so the invalid php 5.6 code is fixed on php 7.0 rule. We don't change to 2 kind of versions, php...
Re-open, it seems cause invalid on valid code: ```php $foo = 'a'; $a = [ 'bar' => [ 'baz' => 'test', ], ]; echo $$foo['bar']['baz']; ```
It seems it always depends of how variable is fetched, see it https://3v4l.org/eip64 vs https://3v4l.org/tYFTb
@corentin-larose after some try, it always depends of what variable and its value, so I am reverting to original functionality. Thank you for understanding.
Please rebase, ensure no Merge/unrleated commit in PR
I wrote a blog post how to rebase :) https://samsonasik.wordpress.com/2015/09/16/practical-git-4-rebasing-conflicted-task-branch-against-primary-branch/
@gsteel use cast is needed to keep existing behaviour, except it needs to go to 4.0.0