rectorphp
/ast page should not use FullyQualified on return true
The true value is not FullyQualified, a Name should be used if as input is not backslashed.
https://getrector.com/ast/d50f4d493f7061f3c419397a744a49e92409c3ce?nodeId=7
It seems only happen on non-namespaced file https://getrector.com/ast/d50f4d493f7061f3c419397a744a49e92409c3ce?nodeId=7
when has namespace, it not fully qualified https://getrector.com/ast/fbf1401fbd04dfd5e9a0858f4936a39ed66cc4dd?nodeId=9
It seems bug on nikic/php-parser on NameContext
https://github.com/nikic/PHP-Parser/blob/fa02db3f30ecdee4142bed51b860e1e3ca20bb5a/lib/PhpParser/NameContext.php#L124-L127
The getNamespaceRelativeName() should be called first.
I created PR on php-parser side:
- https://github.com/nikic/PHP-Parser/pull/1067
Closing as this is way php-parser works, and FQN is not really relevant here. AST form works well and provides all values correctly.
If it get's changed in php-parser, good for the slash, but I don't think it's work it.
