Abdul Malik Ikhsan
Abdul Malik Ikhsan
default `null` value can be removed if next parameter is required, see https://3v4l.org/4pQLN that safe even extended, also, named argument is not used in the test :)
Sign off is needed, read https://github.com/laminas/laminas-code/pull/201/checks?check_run_id=32024385175
@JoolsMcFly @JohJohan could you verify this latest change on this PR? Thank you.
Thank you @neznaika0
@paulbalandan it seems due to mergeable PR: - https://github.com/codeigniter4/CodeIgniter4/pull/9355 @neznaika0 let's reopen
I am thinking on the contrary, the fatal error is expected, when you have fatal error, you can immediatelly see there is BC break, and you can see the upgrade...
constant value set with add if constant exists check seems needed, on downgrade, looking at https://3v4l.org/mHBk2 , the value seems different between PHP 8.1 to PHP 8.3, replace with statement...
@savinmikhail new rule: DowngradeTEnumConstantRector seems needed, to add: ```diff + if (! defined('T_ENUM')) { + define... + ``` Before the statement that use it, there is service `ExprInTopStmtMatcher` https://github.com/rectorphp/rector-downgrade-php/blob/c053b9795a81bb9fd5b8d59e05c7556f19267893/src/NodeAnalyzer/ExprInTopStmtMatcher.php#L28 to...
I will try
another way is you can create your own constants.php and register to your composer.json under autoload -> files config, add if php version and defined check there :)