Abdul Malik Ikhsan
Abdul Malik Ikhsan
Could you provide reproduced repository with github action running? Thanks
@TomasVotruba @jeremyVignelles I am thinking that this rule should only cover `!==` instead of `===`, as it seems valid? it requires some verification tho... ```diff
Oh, the result seems different https://3v4l.org/7cbU6
If the type is exactly of what it defined (sub type), it can be checked by something like: ```php $varType = $this->nodeTypeResolver->getNativeType($varNode); $objectType = new ObjectType($className); if ($varType instanceof ObjectType...
@TomasVotruba `get_class()` is PHP 7.x syntax, this rule is contradictory with `ClassOnObjectRector` as PHP 8.x rule, see this demo: PHP 7.x `GetClassToInstanceOfRector` become instanceof: --- - https://getrector.com/demo/67f35314-d225-4397-8402-81d46edd204d PHP 8.x `ClassOnObjectRector`...
I think the rule can be deprecated/removed. But if we want to keep it, we need to: - check both `get_class()` and `::class` usage for php 7.x and php 8.x...
please create multiple PRs for per-directory basis to make easier to review, also, better fix per error identifier instead of try to fix everything, then you can rebase when one...
I am removing `4.6` label for this PR since it still require some work so we can move forward.
Mock ideas: - once you use mock, you will spend more time fixing mocks.