Simon Conseil

Results 361 comments of Simon Conseil

As a breaking change, removing stuff should be done in the next major version :pray:

To me putting the deprecation in 7.1 is fine.

Could we use `stdbool.h` instead ? (would imply to require c99 but I think we can do that)

You could skip the spectra that are entirely masked (e.g. with `sp.mask.all()`).

I'm not sure that so much code could be removed. astropy's `download_file` is doing basic HTTP things, and most of the code is for caching which is not handled by...

It seems `Sort:` only works for sub-albums currently... and I agree the documentation can be improved.

Hi @cmarmo , `_converted` is populated when columns data is accessed, so if you print a column or the full array it will contain the converted data. With the solution...

Getting back to this one, the memory leak can be fixed by breaking the references on `_col_weakrefs`: ``` new = super().copy(order=order) new._col_weakrefs = weakref.WeakSet() new._coldefs = ColDefs(self._coldefs) new._converted = {}...

> Resetting _converted is also generating the same OSError about heap data, so I only reset _col_weakrefs. Weird but at least we spot that now. I cannot find why so...