Rename bool, true and false to avoid conflicts

[sergiopasra]

The C23 standard makes bool, true and false reserved words. This PR renames bool as boolt_t and true and false as true_v and false_v. This fixes https://github.com/astropy/astroscrappy/issues/94

[saimn]

Could we use stdbool.h instead ? (would imply to require c99 but I think we can do that)

[jehturner]

I found that the Python 3.12 headers (when compiling Cython) seem to require C99 now anyway (which even gcc 4.8 in CentOS 7 can be coerced to support, with the appropriate flag).

[cmccully]

So I would say if we can adopt a standard library, let's do that.

On Fri, Feb 14, 2025 at 12:54 PM jehturner @.***> wrote:

I found that the Python 3.12 headers (when compiling Cython) seem to require C99 now anyway (which even gcc 4.8 in CentOS 7 can be coerced to support, with the appropriate flag).

— Reply to this email directly, view it on GitHub https://github.com/astropy/astroscrappy/pull/95#issuecomment-2659940427, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIVYHAOU34GOM46UNT6WGT2PYUVFAVCNFSM6AAAAABXDIADBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHE2DANBSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***> [image: jehturner]jehturner left a comment (astropy/astroscrappy#95) https://github.com/astropy/astroscrappy/pull/95#issuecomment-2659940427

I found that the Python 3.12 headers (when compiling Cython) seem to require C99 now anyway (which even gcc 4.8 in CentOS 7 can be coerced to support, with the appropriate flag).

— Reply to this email directly, view it on GitHub https://github.com/astropy/astroscrappy/pull/95#issuecomment-2659940427, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIVYHAOU34GOM46UNT6WGT2PYUVFAVCNFSM6AAAAABXDIADBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZHE2DANBSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[astrofrog]

@saimn can we close this?

[saimn]

Yes, superseded by #101.