Simon Conseil

Results 359 comments of Simon Conseil

Please add a `setup_package.py` file to define NPY_NO_DEPRECATED_API and avoid NPY_1_7_API_VERSION warnings (see other subpackages for examples).

I'm not expert with `Angle` but while doing quick tests to play with cython I'm just wondering if we need ufunc/fused types: - from what I can see `Angle` always...

Yes indeed, something like `ignore_dirs` in the collection phase should be doable.

@dhomeier - ping, can you rebase (and have a look at my comment above if you missed it) ?

I cannot reproduce, the submodule loggers inherit the parent's configuration. Example with the test gallery after adding some fake option to ffmpeg: ``` DEBUG: Video size: 240, 98 -> 480,...

No I have never tested on Windows. There are some bug report on Windows (https://github.com/saimn/sigal/labels/windows) so I guess it more or less works but I cannot help with the debugging...

It should work, see for example the test gallery: https://github.com/saimn/sigal/blob/main/tests/sample/pictures/accentu%C3%A9/h%C3%A9lico%C3%AFde.jpg Please provide more details.

We no more use the original `fitsio2.h` from cfitsio so maybe this block can be removed, @astrofrog ? https://github.com/astropy/astropy/blob/e2d4fc65219c9e0712fadea37b77d41180681598/astropy/io/fits/hdu/compressed/src/compression.c#L13-L18 Also should not be executed unless you define `_REENTRANT` (which is...

#14252 removed most of our bundled cfitsio, keeping only the small parts we still need, so I think we no more need this. cc @Cadair as well :)

@tieneupin - which compiling instructions are you referring to ?