Simon Conseil comments

Results 361 comments of


                                            Simon Conseil

Output directory should be outside of the input directory?

Indeed that should work. I guess I added that restriction at the very beginning, probably before `ignore_directories`.

remove old cfitsio compatibility code

Yeah no need to backport, this is really an edge case.

Move astropy to ``src`` directory

Basically src-layout makes it much easier to test the installed version of a package (and thus to test that the package has been packaged/installed correctly), by ensuring that the package...

KeyError after adding a directory to exclude patterns

I found a problem in the ignore_directories logic, hopefully 114f4e2d42c3fb3526b47418a1cd1de44f948b44 should fix that.

KeyError after adding a directory to exclude patterns

@JulienPalard - I couldn't reproduce (see commit above), it works for me with `ignore_directories = [".venv*"]`. Maybe you forgot the star ?

Sigal not found

I never tried on Windows, so cannot really help sorry. This seems a bit weird: ``` WARNING: Ignoring invalid distribution -igal (c:\users\paolo\appdata\roaming\python\python39\site-packages) WARNING: Ignoring invalid distribution -p (c:\python39\lib\site-packages) WARNING: Ignoring...

Accessing a FITS table with a zero-width column generates "ValueError: Inconsistent data column lengths: set([0, 27645])"

Looks like a Table issue (printing the shape-0 column) more than a FITS one, so changing the labels.

Accessing a FITS table with a zero-width column generates "ValueError: Inconsistent data column lengths: set([0, 27645])"

Some progress: there was an issue in `io.fits` which has been fixed in #16894, but reading such a file with `Table.read` still crashes. `QTable.read` seems to work though.

Accessing a FITS table with a zero-width column generates "ValueError: Inconsistent data column lengths: set([0, 27645])"

#16897 fixes the problems with Table/QTable so issue solved :)

index column not preserved on table write/read

There is an old issue (#6925) but this one has more information and an example so maybe we can close the old one?