Robert Timms
Robert Timms
Me too, thanks!
@brosaplanella do you think it's possible to get this done in time for the next release?
It can be removed. It was meant if we included a cylindrical thermal model or extended [this example](https://github.com/pybamm-team/PyBaMM/blob/develop/docs/source/examples/notebooks/models/jelly-roll-model.ipynb) to use a “real” battery model.
Also see [pybamm-eis](https://github.com/pybamm-team/pybamm-eis) which can be used for frequency domain simulations of pybamm models.
Thanks taking this on! For it to work properly we need to wrap all the terms that aren’t a spatial operator in source, eg see https://github.com/pybamm-team/PyBaMM/blob/9415db5037ca5978a91723ff9a64c3c44d85e0e0/src/pybamm/models/submodels/thermal/pouch_cell/pouch_cell_2D_current_collectors.py#L89 I’m not sure this...
The interpretation here is that height times width gives the overlapping electrode pair area (i.e., it doesn't include the overhang).
I’m in favour of updating this formulation. It will be helpful to have reusable and easily interpretable parameters, especially as we look to integrate more hysteresis models.
I’m happy to use this issue to discuss the changes. Could you post your suggestions and we can figure out a plan to move forward?
If you make something a `FunctionParameter`, it can be a function or a parameter. The only thing that is fixed is the arguments of the function. What variables could $\gamma$...