Robert Timms
Robert Timms
I think we should change the default interpolant to be linear. This is normally the default for all other interpolators and is the "safest" option in the sense that you...
Make a `BaseBatterySubmodel` that performs things like checking domains, e.g. ``` ok_domain_list = [ "Negative", "Separator", "Positive", "Negative electrode", "Negative electrolyte", "Separator electrolyte", "Positive electrode", "Positive electrolyte", None, ] ```...
When creating a `SpatialVariable` check the coordinate system against `KNOWN_COORD_SYS` defined [here](https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/expression_tree/independent_variable.py#L8).
### Description Add variables e.g. "Negative electrode Ohmic heating [W.m-3]". Note: depending on which submodel is used, "Electrolyte current density" isn't always a concatenation, so can't be split by domain....
Add an option to include heat of mixing (irreversible) and use the expression for the reversible heating from [this paper](https://arxiv.org/abs/2104.01590)
The parameter [command line interface](https://pybamm.readthedocs.io/en/latest/source/parameters_cli.html?highlight=cli#pybamm.parameters_cli.add_parameter) requires users to use bash. However, there are some python functions defined in `parameters_cli.py` that we could expose so that e.g. instead of ``` %%bash...
It would be good to be able to e.g. run a drive cycle in an experiment until a given voltage, like so: ```python3 import pybamm import pandas as pd import...
It would be nice if you could make a `QuickPlot` with discharge capacity as the x-axis instead of time. This would make it easier to compare solutions where the C-rate...
Add some of the models from the paper [Homogenisation of spirally-wound high-contrast layered materials](https://arxiv.org/abs/2011.04187), S. Psaltis, R. Timms, C.P. Please, S.J. Chapman. - [ ] Add the “reasonably/very conductive” model...
Through homogenization you can show that you can change the parameters in the "2+1D" pouch cell model to be effective parameters that account for the number of layers in the...