Robert Timms
Robert Timms
@medha-14 yes, those are the only two options. I think what I had in mind here is that all the options that can be tuples should be converted to tuples...
need this as part of fixing #4893 . hoping to wrap up today but incase you need a workaround sooner, you need this in `binary_operators.py` lines 1123-1129 ```python3 # anything...
@MarcBerliner not sure if you've seen this but I know you were looking at IDAKLU
@ejfdickinson any comments? I plan to work on this next week
> How should we parameterise this, and do you think the back-end variable implementation of of Wycisk with a variable "Negative electrode OCP hysteresis [V]", which is then scaled by...
done in #4893
@aabills might be good for you to review this one since you've been looking at the composite code a lot recently
In general, I am against adding parameters that aren't in the original paper, but since we already added a bunch of extra degradation parameters in these files it is OK...
@DrSOKane is this ready to be reviewed?
My opinion is that we should remove all of these default options that change based on other options and instead users should explicitly choose all the options they want. If...