Robert Timms
Robert Timms
can you try using a linear interpolant rather than a cubic one? something like ```python3 parameter_values = pybamm.ParameterValues("Okane2022") path = # path to where the csv is stored graphite_LGM50_ocp_Chen2020_data =...
Since this was the OCP used in that paper I think we should leave it as-is so that the parameter set stays true to the reference.
Fixed by https://github.com/pybamm-team/PyBaMM/pull/5138
Thanks @ejfdickinson this is a good summary. I agree, mapping the constant is easy. The functions are more complicated. Tackling this probably requires some battery knowledge too. As highlighted, the...
IMO we should fix this before 24.5 proper. I don't know what logic changed or if there was a longer default before. Update: the logic used to be ```python3 if...
Alternatively, should we require a duration to avoid unexpected behaviour?
It got moved to the `Step` class instead of the `Simulation` class. It's easy to put the same logic back in for C-rate, but not current, as the default duration...
Tagging https://github.com/pybamm-team/PyBaMM/issues/2682 as related. Currently the electrode state of health models in pybamm don't support blended electrodes.
Yes, this is simply because `calc_esoh` predates blended electrodes. I’m open to changing this.
Thanks for all your effort in highlighting these discrepancies. They all come about because in PyBaMM we use a composite expression for all the quantities involving the electrolyte variables whereas...