PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard
verified publisher icon pybamm-team

Remove "cylindrical" macro geometry?

Open valentinsulzer opened this issue 10 months ago • 1 comments

https://github.com/pybamm-team/PyBaMM/blob/86b00cecbdfc7666c6e9705b49cbd0376534e13e/src/pybamm/geometry/battery_geometry.py#L153-L164

This is not used anywhere within the repo. Is it used by an external example? @rtimms

valentinsulzer avatar Feb 17 '25 17:02 valentinsulzer

It can be removed. It was meant if we included a cylindrical thermal model or extended this example to use a “real” battery model.

rtimms avatar Feb 18 '25 03:02 rtimms