pybamm-team
Extend `pybamm.ParameterValues.create_from_bpx()` to automate initial concentrations for blended electrodes
Description
Calling pybamm.ParameterValues.create_from_bpx() with a BPX file containing a blended electrode returns a warning as follows:
Initial concentrations cannot be set using stoichiometry limits for blend electrodes. Please set the initial concentrations manually.
The method could automate this calculation by solving the equations specified in the BPX standard.
Motivation
No response
Possible Implementation
No response
Additional context
No response
Tagging https://github.com/pybamm-team/PyBaMM/issues/2682 as related. Currently the electrode state of health models in pybamm don't support blended electrodes.
@rtimms Off-topic I know, but for this reason I find it odd that calc_esoh=True is the default in pybamm.Simulation.solve().
Yes, this is simply because calc_esoh predates blended electrodes. I’m open to changing this.
The proper fix, which we are planning to do, is to do "just in time" calculations of esoh values only when they are requested
